Handle special cases for File.createTempFile
#133530
Conversation
ldematte
added
>non-issue
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
IIRC I didn't do this because we implicitly allow access to the temp directory for all code, so I only overrode the methods that took in a base dir to create a temp file. This should work though, it just means additional checks (we already grant the tmp dir access automatically in module policies, do we also do that for eg the unnamed module that apm agent uses?)
|
It's a good point; at first, I just added a case to the existing What I did not like about it is that we now have the "we implicitly allow access to the temp directory for all code" policy in yet another place, so I change it this way. I'm fine either way really, even just adding the |
Yep, all paths (including APM_MODULE and UNKNOWN) all use a FileAccessTree. They might have a |
We were missing a couple of cases where File.createTempFile (from java.io) are defaulting to the default temp directory. This PR addresses that. Fixes elastic#130086
We were missing a couple of cases where File.createTempFile (from java.io) are defaulting to the default temp directory. This PR addresses that. Fixes elastic#130086
…c#133647) We were missing a couple of cases where File.createTempFile (from java.io) are defaulting to the default temp directory. This PR addresses that. Fixes elastic#130086
…c#133647) We were missing a couple of cases where File.createTempFile (from java.io) are defaulting to the default temp directory. This PR addresses that. Fixes elastic#130086
3 participants
We were missing a couple of cases where
File.createTempFile(fromjava.io) are defaulting to the default temp directory.This PR addresses that.
Fixes #130086